Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Add pretty-printed XML output option - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: [PATCH] Add pretty-printed XML output option
Date
Msg-id CAAhFRxjM4XZeQhKTfSKeQSyMAK6xssOu6UCT2rmVkBfi4NtmJQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add pretty-printed XML output option  (Jim Jones <jim.jones@uni-muenster.de>)
Responses Re: [PATCH] Add pretty-printed XML output option
List pgsql-hackers
Tree view 
On Thu, Feb 16, 2023 at 2:12 PM Jim Jones <jim.jones@uni-muenster.de> wrote:
>
> I'm squashing v12-0001 and v12-0002 (v13 attached).
I've looked into the patch. The code looks to conform to usual expectations.
One nit: this comment should have just one asterisk.
+ /**
And I have a dumb question: is this function protected from using
external XML namespaces? What if the user passes some xmlns that will
force it to read namespace data from the server filesystem? Or is it
not possible? I see there are a lot of calls to xml_parse() anyway,
but still...

Best regards, Andrey Borodin.

pgsql-hackers by date:

Previous
From: Andrey Borodin
Date:
Subject: psql \watch 2nd argument: iteration count
Next
From: Andres Freund
Date:
Subject: Re: Introduce list_reverse() to make lcons() usage less inefficient