Postgres Pro
Downloads
Home   >   mailing lists

[Patch]: Installer: pgAdmin4 should not install in special character path - Mailing list pgadmin-hackers

From Paresh More
Subject [Patch]: Installer: pgAdmin4 should not install in special character path
Date
Msg-id CAAgiCNFSum4v+HqOz=fcRLaAXuey-Zw_oMrGGKrNX+dEV-JFjw@mail.gmail.com
Whole thread Raw
Responses Re: [Patch]: Installer: pgAdmin4 should not install in specialcharacter path  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Hello Team,

I have made three changes for installer generation scripts.

1) Modified Make-MinGW.bat to support yarn and nodejs validation in the script and also QT 5.9.1 support.

2) Bug fix for RM1365.
Currently string datatypes used in Inno tool does not support regular expression, so added a user function which will do path validation and it would be work fine for inno unicode setup.

3) Restructured  installer script so that it should support unicode inno and for RM1365 as well i.e Inno Setup Installer(unicode) also updated README file for the same.


Please note - Installer path validation is invoked two times

1) Inno tool internally validate's path which user program do not have access to it , so section [MESSAGE] error string message will be used to show error message string. 

2) From the code section, so section [CustomMessages] error message will be used.

For both (1) and (2) common error message will be used.


Attached is the patch 


--

Thanks & Regards 

Paresh More

NEW-EDB-logo-4c

Pune, India.

Attachment

pgadmin-hackers by date:

Previous
From: Murtuza Zabuawala
Date:
Subject: Re: [pgAdmin4][Patch]: To make error message uniform for Createschema action
Next
From: Murtuza Zabuawala
Date:
Subject: [pgAdmin4][Patch]: Add support for time without time zone