On Thu, Mar 31, 2022 at 9:43 AM Robert Haas <robertmhaas@gmail.com> wrote:
>
> On Thu, Mar 31, 2022 at 9:17 AM James Coleman <jtc331@gmail.com> wrote:
> > All right, thanks for feedback. Attached is v2 with such a change.
> > I've not included examples, and I'm about 50/50 on doing so. What are
> > your thoughts on adding in parens "e.g., changing from varchar to text
> > avoids rebuilding indexes while changing from text to a domain of text
> > with a different collation will require rebuilding indexes"?
>
> On the patch, I suggest that instead of saying "can verify that sort
> order and/or hashing semantics are unchanged" you say something like
> "can verify that the new index would be logically equivalent to the
> current one", mostly because I do not think that "and/or" looks very
> good in formal writing.
Agreed re: "and/or".
> I think it would be fine to include examples, but I think that the
> phrasing you suggest here doesn't seem great. I'm not sure how to fix
> it exactly. Maybe it needs a little more explanation?
Is the attached more along the lines of what you were thinking?
Thanks,
James Coleman
