Re: Last gasp - Mailing list pgsql-hackers

From Daniel Farina
Subject Re: Last gasp
Date
Msg-id CAAZKuFbHQA6Q3hO5amMLh6Zvh=-8tdKeQFUacdDVREnvp889Jg@mail.gmail.com
Whole thread Raw
In response to Re: Last gasp  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Last gasp  (Greg Smith <greg@2ndQuadrant.com>)
List pgsql-hackers
On Thu, Apr 5, 2012 at 1:40 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> Yep.  I think Tom and I and others were all pretty clear that there
> were not enough people reviewing this CommitFest,

Sorry to derail the thread just a little, but I've thought a little
about this and I wonder if part of the problem is just that some of
the patches are really large: doing a really thorough job reviewing is
quite demanding, and the amount and kind of lore everyone has at their
disposal is different.

To get to the point, I wonder if it makes sense for someone who has a
better sense a-priori what they're looking for in a committable patch
(i.e. a committer, or someone with a telepathic link to one or more)
to delegate specific pieces of patches for thorough review, sketching
some thoughts about pitfalls or hazards to look for.  Think of it as a
patch checklist that is informed by the experience of a committer
skimming its contents.

--
fdr


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Last gasp
Next
From: Dimitri Fontaine
Date:
Subject: Re: Last gasp