Re: [PATCH] Expose port->authn_id to extensions and triggers - Mailing list pgsql-hackers

Hello,

On Fri, Aug 12, 2022 at 6:34 AM Drouvot, Bertrand <bdrouvot@amazon.com> wrote:
> +typedef struct
> +{
> +       /*
> +        * Authenticated identity.  The meaning of this identifier is
> dependent on
>
> has to be replaced by:
>
> +typedef struct ClientConnectionInfo
> +{
> +       /*
> +        * Authenticated identity.  The meaning of this identifier is
> dependent on

Okay, will do in the next patch (coming soon).

> +        * Authenticated identity.  The meaning of this identifier is
> dependent on
>
> There is one extra space before "The"

This comment block was just moved verbatim; the double-spaced
sentences were there before.

>  From a coding style point of view, shouldn't "ClientConnectionInfo
> MyClientConnectionInfo;" be moved to the top of the file?

The style in this file seems to be to declare the variables at the top
of the section in which they're used. See the sections for "User ID
state" and "Library preload support".

Thanks,
--Jacob