Re: [Commitfest 2022-07] Patch Triage: Needs Review, Part 1 - Mailing list pgsql-hackers

From Jacob Champion
Subject Re: [Commitfest 2022-07] Patch Triage: Needs Review, Part 1
Date
Msg-id CAAWbhmhn2orPoCHq3yUpqoqay264x=wZQSf5D9FfZZVscYMuog@mail.gmail.com
Whole thread Raw
In response to Re: [Commitfest 2022-07] Patch Triage: Needs Review, Part 1  (Julien Rouhaud <rjuju123@gmail.com>)
Responses Re: [Commitfest 2022-07] Patch Triage: Needs Review, Part 1
List pgsql-hackers
Hi Julien,

On Thu, Jul 28, 2022 at 11:38 PM Julien Rouhaud <rjuju123@gmail.com> wrote:
> > - Add extra statistics to explain for Nested Loop
> >   https://commitfest.postgresql.org/38/2765/
> >
> > [...]
>
> As I mentioned in [1], this patch breaks the current assumption that
> INSTRUMENT_ALL will lead to statement-level metrics that are generally useful.
> According to the benchmark, the proposed patch would add a 1.5% overhead for
> pg_stat_statements or any other similar extension that relies on INSTRUMENT_ALL
> for no additional information, and I don't think it's acceptable.

(I'm missing the [1] link.) From skimming the end of the thread, it
looks like Ekaterina responded to that concern and was hoping for
feedback. If you still think it doesn't go far enough, would you mind
dropping a note in the thread? Then we can mark WoA and go from there.

Thanks!
--Jacob



pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: [Commitfest 2022-07] Patch Triage: Needs Review, Part 1
Next
From: Julien Rouhaud
Date:
Subject: Re: [Commitfest 2022-07] Patch Triage: Needs Review, Part 1