[PATCH] pg_dump: Sort overloaded functions in deterministic order - Mailing list pgsql-hackers

From Joel Jacobson
Subject [PATCH] pg_dump: Sort overloaded functions in deterministic order
Date
Msg-id CAASwCXdCCw=1mzxSN2+V41V+i6nYpvU9TRhZ7Skx=Cev18YuTg@mail.gmail.com
Whole thread Raw
List pgsql-hackers
Makes pg_dump sort overloaded functions in deterministic order.

The field "proiargs" has been added to FuncInfo and is set by getFuncs()
and getAggregates() for all functions and aggregates.

DOTypeNameCompare uses this field to break ties if the name and number of
arguments are the same. This avoid having to default to OID sorting.

This patch is independent from the ongoing discussion of the pg_dump --split
option. Even if we can't agree on how to do the splitting of objects into
files, it still makes sense to fix the sort order of overloaded functions.

Attachment

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: bgwriter, regression tests, and default shared_buffers settings
Next
From: Bruce Momjian
Date:
Subject: Re: Using pg_upgrade on log-shipping standby servers