Re: shared-memory based stats collector - v66 - Mailing list pgsql-hackers

From Melanie Plageman
Subject Re: shared-memory based stats collector - v66
Date
Msg-id CAAKRu_Zu=8WD3sHyiU-b_DPmP5ic_9CHw9S1vAex44VcNUUNQA@mail.gmail.com
Whole thread Raw
In response to Re: shared-memory based stats collector - v66  (Melanie Plageman <melanieplageman@gmail.com>)
List pgsql-hackers
On Sun, Mar 20, 2022 at 4:56 PM Melanie Plageman
<melanieplageman@gmail.com> wrote:
>
> Addressed all of these points in
> v2-0001-add-replica-cleanup-tests.patch
>
> also added a new test file in
> v2-0002-Add-TAP-test-for-discarding-stats-after-crash.patch
> testing correct behavior after a crash and when stats file is invalid
>

Attached is the last of the tests confirming clean up for stats in the
shared stats hashtable (these are for the subscription stats).

I thought that maybe these tests could now use
pg_stat_force_next_flush() instead of poll_query_until() but I wasn't
sure how to ensure that the error has happened and the pending entry has
been added before setting force_next_flush.

I also added in tests that resetting subscription stats works as
expected.

- Melanie

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: [PATCH] add relation and block-level filtering to pg_waldump
Next
From: Tomas Vondra
Date:
Subject: Re: logical decoding and replication of sequences