Re: Understanding when VM record needs snapshot conflict horizon - Mailing list pgsql-hackers

From Melanie Plageman
Subject Re: Understanding when VM record needs snapshot conflict horizon
Date
Msg-id CAAKRu_ZZ8jzUSs_Lvjr3N9XbYFFe99zczT3_uM5tZuCeT2CfXA@mail.gmail.com
Whole thread Raw
In response to Re: Understanding when VM record needs snapshot conflict horizon  (Dilip Kumar <dilipbalaut@gmail.com>)
List pgsql-hackers
On Sun, May 25, 2025 at 6:45 AM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>
> IMHO, if we include snapshot conflict horizon in cases where it is not
> necessary, don't you think it will impact performance on standby?
> because now it has to loop through the procarray on standby to check
> whether there is any conflict before applying this WAL.

Yep, that's a good point. In my patch set to combine the prune/freeze
record and visible record, the only time we could omit the snapshot
conflict horizon after phase I of vacuum in this combined record is
when the heap page was unmodified by phase I and the heap page was
already marked all-visible in the VM and is only being set all-frozen.
I will make sure that the snapshot conflict horizon is omitted in that
case to ensure we don't spend more time on the standby to check for
conflicts.

- Melanie



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Assert("vacrel->eager_scan_remaining_successes > 0")
Next
From: Robert Haas
Date:
Subject: Re: Tightening DecodeNumberField's parsing rules