Correct comment in StartupXLOG(). - Mailing list pgsql-hackers

From Amul Sul
Subject Correct comment in StartupXLOG().
Date
Msg-id CAAJ_b97Hf+1SXnm8jySpO+Fhm+-VKFAAce1T_cupUYtnE3Nxig@mail.gmail.com
Whole thread Raw
Responses Re: Correct comment in StartupXLOG().
List pgsql-hackers
Hi,

SharedRecoveryState member of XLogCtl is no longer a boolean flag, got changes
in 4e87c4836ab9 to enum but, comment referring to it still referred as the
boolean flag which is pretty confusing and incorrect.

Also, the last part of the same comment is as:

" .. although the boolean flag to allow WAL is probably atomic in
itself, .....",

I am a bit confused here too about saying "atomic" to it, is that correct?
I haven't done anything about it, only replaced the "boolean flag" to "recovery
state" in the attached patch.

Regards,
Amul

Attachment

pgsql-hackers by date:

Previous
From: japin
Date:
Subject: Re: Support ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION ... syntax
Next
From: Antonin Houska
Date:
Subject: Re: POC: Cleaning up orphaned files using undo logs