Re: TAP test to cover "EndOfLogTLI != replayTLI" case - Mailing list pgsql-hackers

From Amul Sul
Subject Re: TAP test to cover "EndOfLogTLI != replayTLI" case
Date
Msg-id CAAJ_b97D+gyvh-=9VCX7_Cvr9Do-_pRSjrePKmjh4o21Dy9+2w@mail.gmail.com
Whole thread Raw
In response to Re: TAP test to cover "EndOfLogTLI != replayTLI" case  (Andres Freund <andres@anarazel.de>)
Responses Re: TAP test to cover "EndOfLogTLI != replayTLI" case
List pgsql-hackers
On Mon, Jan 10, 2022 at 8:25 AM Andres Freund <andres@anarazel.de> wrote:
>
> Hi,
>
> On 2021-11-23 11:43:21 +0530, Amul Sul wrote:
> > Attached patch covers a case where TLI in the filename for a
> > record being read is different from where it belongs to. In other
> > words, it covers following case noted in StartupXLOG():
>
> > Thoughts? Suggestions?
>
> It seems the test isn't quite reliable. It occasionally fails on freebsd,
> macos, linux and always on windows (starting with the new CI stuff, before the
> test wasn't run).
>
> See https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/36/3427
>

Thanks for the note, I can see the same test is failing on my centos
vm too with the latest master head(376ce3e404b).  The failing reason is
the "recovery_target_inclusive = off" setting which is unnecessary for
this test, the attached patch removing the same.

Regards,
Amul

Attachment

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Fix a possible typo in rewriteheap.c code comments
Next
From: Andres Freund
Date:
Subject: pg_upgrade verbosity when redirecting output to log file