Postgres Pro
Downloads
Home   >   mailing lists

Re: prevent immature WAL streaming - Mailing list pgsql-hackers

From Amul Sul
Subject Re: prevent immature WAL streaming
Date
Msg-id CAAJ_b97=34F9V99rO1RyGbKaUzyPiefeCWwa8U4pm2E2hZmKwA@mail.gmail.com
Whole thread Raw
In response to Re: prevent immature WAL streaming  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: prevent immature WAL streaming  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Tree view 
Hi,

On Wed, Sep 29, 2021 at 8:14 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> On 2021-Sep-24, Alvaro Herrera wrote:
>
> > Here's the set for all branches, which I think are really final, in case
> > somebody wants to play and reproduce their respective problem scenarios.
> > Nathan already confirmed that his reproducer no longer shows a problem,
> > and this version shouldn't affect that.
>
> Pushed.  Watching for buildfarm fireworks now.
>

While reading this commit (ff9f111bce24), wondered can't we skip
missingContrecPtr global variable declaration and calculate that from
abortedRecPtr value whenever it needed. IIUC, missingContrecPtr is the
next page to the page that abortedRecPtr contain and that can be
calculated as "abortedRecPtr + (XLOG_BLCKSZ - (abortedRecPtr %
XLOG_BLCKSZ))", thoughts? Please correct me if I'm missing something,
thanks.

Regards,
Amul

pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: Transactions involving multiple postgres foreign servers, take 2
Next
From: vignesh C
Date:
Subject: pg_dump does not dump tables created in information_schema schema