Re: Add system identifier to backup manifest - Mailing list pgsql-hackers

From Amul Sul
Subject Re: Add system identifier to backup manifest
Date
Msg-id CAAJ_b96uU1aSvuzTt4AO+y18Z+o=_s8Zxbo2Dy4Wn=5vRGKPKw@mail.gmail.com
Whole thread Raw
In response to Re: Add system identifier to backup manifest  (Amul Sul <sulamul@gmail.com>)
Responses Re: Add system identifier to backup manifest
List pgsql-hackers


On Mon, Jan 22, 2024 at 10:08 AM Amul Sul <sulamul@gmail.com> wrote:


On Fri, Jan 19, 2024 at 10:36 PM Amul Sul <sulamul@gmail.com> wrote:
On Wed, Jan 17, 2024 at 8:40 PM Robert Haas <robertmhaas@gmail.com> wrote:


Updated version is attached.

Another updated version attached -- fix missing manifest version check in
pg_verifybackup before system identifier validation.

Thinking a bit more on this, I realized parse_manifest_file() has many out
parameters. Instead parse_manifest_file() should simply return manifest data
like load_backup_manifest().  Attached 0001 patch doing the same, and removed
parser_context structure, and added manifest_data, and did the required
adjustments to pg_verifybackup code.

Regards,
Amul

Attachment

pgsql-hackers by date:

Previous
From: Konstantin Knizhnik
Date:
Subject: Re: index prefetching
Next
From: Masahiko Sawada
Date:
Subject: Re: [PoC] Improve dead tuple storage for lazy vacuum