Re: [HACKERS] Declarative partitioning - another take - Mailing list pgsql-hackers

From amul sul
Subject Re: [HACKERS] Declarative partitioning - another take
Date
Msg-id CAAJ_b95g5AgkpJKbLajAt8ovKub874-B9X08PiOqHvVfMO2mLw@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Declarative partitioning - another take  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [HACKERS] Declarative partitioning - another take  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
List pgsql-hackers
Hi Amit,

Regarding following code in ATExecDropNotNull function, I don't see
any special check for RANGE partitioned, is it intended to have same
restriction for LIST partitioned too, I guess not?
 /*    * If the table is a range partitioned table, check that the column is not    * in the partition key.    */   if
(rel->rd_rel->relkind== RELKIND_PARTITIONED_TABLE)   {       PartitionKey key = RelationGetPartitionKey(rel);       int
       partnatts = get_partition_natts(key),                   i;
 
       for (i = 0; i < partnatts; i++)       {           AttrNumber  partattnum = get_partition_col_attnum(key, i);
           if (partattnum == attnum)               ereport(ERROR,
(errcode(ERRCODE_INVALID_TABLE_DEFINITION),                       errmsg("column \"%s\" is in range partition key",
                         colName)));       }   }
 

Regards,
Amul



pgsql-hackers by date:

Previous
From: Yuriy Zhuravlev
Date:
Subject: Re: [HACKERS] WIP: About CMake v2
Next
From: Pavel Raiskup
Date:
Subject: Re: [HACKERS] [PATCH] configure-time knob to set default ssl ciphers