Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Fast ALTER TABLE ADD COLUMN with a non-NULL default - Mailing list pgsql-committers

From Andrew Dunstan
Subject Re: pgsql: Fast ALTER TABLE ADD COLUMN with a non-NULL default
Date
Msg-id CAA8=A7_p3r4GiEV9=nbiwy8=skFTzRN2OSvLN+Un1gJLPwdusA@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Fast ALTER TABLE ADD COLUMN with a non-NULL default  (Andres Freund <andres@anarazel.de>)
Responses Re: pgsql: Fast ALTER TABLE ADD COLUMN with a non-NULL default  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
Tree view 
On Wed, Mar 28, 2018 at 11:30 AM, Andres Freund <andres@anarazel.de> wrote:
> Hi,
>
> On 2018-03-28 00:56:10 +0000, Andrew Dunstan wrote:
>> Fast ALTER TABLE ADD COLUMN with a non-NULL default
>
>> src/backend/executor/execExprInterp.c       |   2 +-
>
> I bet this'll break JITed tuple deforming... We'll have to emit a call
> to the new slot missingattrs function, instead of using memset directly.
>
> Do you want to attempt to take care of it, or should I?
>

Please do. I guess I need to do some enabling of that in my test setup.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Fast ALTER TABLE ADD COLUMN with a non-NULL default
Next
From: Andres Freund
Date:
Subject: Re: pgsql: Fast ALTER TABLE ADD COLUMN with a non-NULL default