Re: [PATCH] Clear up perlcritic 'missing return' warning - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: [PATCH] Clear up perlcritic 'missing return' warning
Date
Msg-id CAA8=A7-uZk2GSXpzHztghfhK1Uq68PtFyzegL3sPP6Mt17Sg4A@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Clear up perlcritic 'missing return' warning  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: [PATCH] Clear up perlcritic 'missing return' warning  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
List pgsql-hackers
On Wed, May 23, 2018 at 1:45 PM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
> On 2018-May-23, Andrew Dunstan wrote:
>
>> And yes, the idea is that if we do this then we adopt a perlcritic
>> policy that calls it out when we forget.
>
> If we can have a buildfarm animal that runs perlcritic that starts green
> (and turns yellow with any new critique), with a config that's also part
> of our tree, so we can easily change it as we see fit, it should be
> good.
>


Should be completely trivial to do. We already have the core
infrastructure - I added it a week or two ago.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Subplan result caching
Next
From: Tom Lane
Date:
Subject: Re: printf format selection vs. reality