> I think that this is hiding a behavior change while adding new
> counters, and both changes are independent.
That's a fair point.
> Another thing that is
> slightly incorrect to do if we take the argument of only adding the
> counters is moving around the call of pgstat_progress_end_command(),
> because it's not really wrong as-is, either. I'd suggest to make all
> that a separate discussion.
Yeah, we have inconsistency between when vacuum and analyze
command ends as well as inconsistency between the time
reported to pg_stats vs the logs. I will start a follow-up thread for
this.
> I have put my hands on this patch, and at the end I think that we
> should just do the attached, which is simpler and addresses your
> use-case. Note also that the end time is acquired while the entries
> are not locked in the report routines, and some tweaks in the docs and
> comments.
Thanks for the update. This LGTM.
Regards,
Sami
