Re: Improve explicit cursor handling in pg_stat_statements - Mailing list pgsql-hackers

From Sami Imseih
Subject Re: Improve explicit cursor handling in pg_stat_statements
Date
Msg-id CAA5RZ0uakH417UU+pZc=XB3XwA=1iPb5J-aPUdvL6xYvE478cw@mail.gmail.com
Whole thread Raw
In response to Re: Improve explicit cursor handling in pg_stat_statements  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Improve explicit cursor handling in pg_stat_statements
List pgsql-hackers
> +  * If an direction_keyword (i.e., FETCH FORWARD) is used, set this field
> +  * to distinguish it from its numeric counterpart (i.e., FETCH 1). This
> +  * value is set only within gram.y.
>
> One nitpick comment here is that I would have mentioned that this
> matters for query jumbling.

Done

> The tests can be in cursors.sql and not utility.sql, which is the test
> area for...  Cursors.  :D

Yeah, not sure how I missed the cursor.sql file.

> FetchDirectionKeywords could be in typedefs.list to avoid the
> indentation accident with the structure definition.

Done.

v5 attached.

--
Sami

Attachment

pgsql-hackers by date:

Previous
From: Nitin Motiani
Date:
Subject: Re: Adding pg_dump flag for parallel export to pipes
Next
From: Ashutosh Bapat
Date:
Subject: Re: pg_get_multixact_members not documented