Postgres Pro
Downloads
Home   >   mailing lists

Re: Proposal to CREATE FOREIGN TABLE LIKE - Mailing list pgsql-hackers

From Sami Imseih
Subject Re: Proposal to CREATE FOREIGN TABLE LIKE
Date
Msg-id CAA5RZ0ts9vBOQ1=igQfzjYT5Df6Lt=hHn=9wD13PxWMsu18dfQ@mail.gmail.com
Whole thread Raw
In response to Re: Proposal to CREATE FOREIGN TABLE LIKE  (Álvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Tree view 
> Patch V2 addressed the comments.

Overall this LGTM.

I still see a "no real storage" in v2 that should be removed
from the documentation.

+ Foreign tables have no real storage in PostgreSQL.
+ Inapplicable options: <literal>INCLUDING INDEXES</literal>,
<literal>INCLUDING STORAGE</literal>,

I think the test coverage to check for the negative conditions only is
enough.

Regards,

Sami

pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: describe special values in GUC descriptions more consistently
Next
From: "Devulapalli, Raghuveer"
Date:
Subject: RE: Improve CRC32C performance on SSE4.2