> On Tue, Mar 18, 2025 at 11:21 PM Sami Imseih <samimseih@gmail.com> wrote:
> > > > Do you want to propose a patch?
> > >
> > > yes, will attach a patch shortly.
> >
> > Attached is a patch to add a hook to allow extensions
> > to add additional option validations. The hook takes
> > in the ExplainState as an argument and returns void.
> > It is expected the extension will raise an error if the
> > validation fails.
>
> Since the new hook will be called from explain_state.c, please declare
> it in explain_state.h.
done
> I think the header-file comment should be just one line rather than a
> block comment as we do for other hooks in this area. If you think a
> more detailed explanation is needed, I'd put that in the .c file.
on second thought, no reason for the detailed explanation...
> Is there any value in passing "options" or "pstate" to the hook?
> Couldn't the hook want to use "pstate" for error reporting purposes?
... as I made the hook signature match that of
ParseExplainOptionList, so both pstate and the options list
are now available to the hook.
--
Sami Imseih
Amazon Web Services (AWS)
