Re: [PATCH v1] eliminate duplicate code in table.c - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: [PATCH v1] eliminate duplicate code in table.c
Date
Msg-id CAA4eK1Ly32xGJHN-=0vAxz7UqXisvqrSDiB0fXByHUeh1SdF2Q@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH v1] eliminate duplicate code in table.c  (Aleksander Alekseev <aleksander@timescale.com>)
Responses Re: [PATCH v1] eliminate duplicate code in table.c
List pgsql-hackers
On Thu, Jul 21, 2022 at 6:12 PM Aleksander Alekseev
<aleksander@timescale.com> wrote:
>
> Hi Alvaro,
>
> > Hmm, but see commit 2ed532ee8c47 about this kind of check.  Perhaps we
> > should change these error messages to conform to the same message style.
>
> Good point! Done.
>

Yeah, that's better. On again thinking about the function name, I
wonder if validate_relation_type() suits here as there is no generic
object being passed?

-- 
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Remove fls(), use pg_bitutils.h facilities instead?
Next
From: Bruce Momjian
Date:
Subject: Re: System catalog documentation chapter