Re: [COMMITTERS] pgsql: Don't generate parallel paths for rels with parallel-restricted - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: [COMMITTERS] pgsql: Don't generate parallel paths for rels with parallel-restricted
Date
Msg-id CAA4eK1Lu1es_UFaDrMjmRudUD_ac0Scn+T=RoTrAh3ePPnipuw@mail.gmail.com
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Don't generate parallel paths for rels with parallel-restricted  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [COMMITTERS] pgsql: Don't generate parallel paths for rels with parallel-restricted
Re: [COMMITTERS] pgsql: Don't generate parallel paths for rels with parallel-restricted
List pgsql-hackers
On Fri, Jun 10, 2016 at 8:20 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Amit Kapila <amit.kapila16@gmail.com> writes:
> > On Thu, Jun 9, 2016 at 11:38 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >> Robert Haas <robertmhaas@gmail.com> writes:
> >>> Could you answer my question about whether adjust_appendrel_attrs()
> >>> might translate Vars into non-Vars?
>
> >> Yes, absolutely.
>
> > Isn't this true only for UNION ALL cases and not for inheritance child
> > relations (at least that is what seems to be mentioned in comments
> > for translated_vars in AppendRelInfo)?
>
> Correct.
>
> > If that is right, then I think
> > there shouldn't be a problem w.r.t parallel plans even if
> > adjust_appendrel_attrs() translate Vars into non-Vars, because for UNION
> > ALL it seems parent rels rtekind is RTE_SUBQUERY and we consider such rels
> > as parallel unsafe (see set_rel_consider_parallel()).
>
> Hm, that would explain why you haven't been able to exhibit a bug on HEAD
> as it stands;
>

Right, so I have moved "Failed assertion in parallel worker (ExecInitSubPlan)" item to CLOSE_WAIT state as I don't think there is any known pending issue in that item.  I have moved it to CLOSE_WAIT state because we have derived our queries to reproduce the problem based on original report[1].  If next run of sqlsmith doesn't show any problem in this context then we will move it to resolved.


pgsql-hackers by date:

Previous
From: Thom Brown
Date:
Subject: Confusing recovery message when target not hit
Next
From: Sridhar N Bamandlapally
Date:
Subject: Re: Online DW