On Fri, Sep 13, 2019 at 11:59 PM James Coleman <jtc331@gmail.com> wrote:
>
> On Sat, Aug 31, 2019 at 10:51 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
>
> Updated patch attached. I changed the wording to be about conflicting
> locks rather than a single lock type, added a link to the conflicting
> locks table, and fixed a few sgml syntax issues in the original.
>
I see error while compiling this patch on HEAD. See the below error:
/usr/bin/xmllint --path . --noout --valid postgres.sgml
postgres.sgml:833: element xref: validity error : IDREF attribute
linkend references an unknown ID
"mvcc-locking-tables-table-lock-compatibility"
make: *** [check] Error 4
The tag id mvcc-locking-tables-table-lock-compatibility is wrong. The
other problem I see is the wrong wording in one of the literals. I
have fixed both of these issues and slightly tweaked one of the
sentence. See the updated patch attached. On which version, are you
preparing this patch? I see both HEAD and 9.4 has the problems fixed
by me.
Let me know what you think of attached? I think we can back-patch
this patch. What do you think? Does anyone else have an opinion on
this patch especially if we see any problem in back-patching this?
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
