Re: Fix assert failure when decoding XLOG_PARAMETER_CHANGE on primary - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Fix assert failure when decoding XLOG_PARAMETER_CHANGE on primary
Date
Msg-id CAA4eK1LQbm7JQA8feNoztDFccduFTVFs+51hm_U56tvunCAmOg@mail.gmail.com
Whole thread Raw
In response to Re: Fix assert failure when decoding XLOG_PARAMETER_CHANGE on primary  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Fix assert failure when decoding XLOG_PARAMETER_CHANGE on primary
List pgsql-hackers
On Thu, Feb 6, 2025 at 12:30 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> I've updated the patch accordingly.
>

Today, again thinking about the proposed fix, I was wondering about
the following case. Say, on hot_standby, the user created a logical
slot, then shut down hot_standby, turn off the hot_standby flag, and
restart standby. This is allowed today but not after the patch. It is
possible that the user can promote a non-hot_standby server after its
restart in the previous step and can reuse the logical slot. So, is it
okay to change this behavior? If not, then we may need to go back to
the first fix proposed by you in this thread.

--
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Introduce XID age and inactive timeout based replication slot invalidation
Next
From: Bertrand Drouvot
Date:
Subject: Re: Failed assertion with jit enabled