Re: row filtering for logical replication - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: row filtering for logical replication
Date
Msg-id CAA4eK1LHQ+hoj_A5TPuhEfK90aK1psacVZ9TRdUpsyRWnKPH7A@mail.gmail.com
Whole thread Raw
In response to RE: row filtering for logical replication  ("houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>)
Responses Re: row filtering for logical replication
List pgsql-hackers
On Tue, Feb 15, 2022 at 7:57 AM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:
>
> On Monday, February 14, 2022 8:56 PM houzj.fnst@fujitsu.com wrote:
> >
> > On Friday, February 11, 2022 5:02 PM houzj.fnst@fujitsu.com wrote:
> > >
> > > Attach the v81 patch which addressed above comments.
> >
> > Attach the v82 patch which was rebased based on recent commit.
> >
> > The new version patch also includes the following changes:
> >
> > - disallow specifying row filter for partitioned table if pubviaroot is false.
> >   Since only the partition's row filter would be used if pubviaroot is false,
> >   so disallow this case to avoid confusion.

I have slightly modified the error messages and checks for this
change. Additionally, I changed a few comments and adapt the test case
for changes in commit 549ec201d6132b7c7ee11ee90a4e02119259ba5b.

The patch looks good to me. I am planning to commit this later this
week (on Friday) unless there are any major comments.

-- 
With Regards,
Amit Kapila.

Attachment

pgsql-hackers by date:

Previous
From: Wenjing Zeng
Date:
Subject: Re: [Proposal] Global temporary tables
Next
From: Greg Nancarrow
Date:
Subject: Re: On login trigger: take three