Downloads
Home   >   mailing lists

Re: Minor patch; missing comment update in worker.c - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Minor patch; missing comment update in worker.c
Date
Msg-id CAA4eK1LExxA9zM6jZkQwCMQWHwWMaKwOht=C0f--sDWpdaOYtQ@mail.gmail.com
Whole thread Raw
In response to Re: Minor patch; missing comment update in worker.c  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Tree view 
On Mon, Jun 23, 2025 at 8:56 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Mon, Jun 23, 2025 at 8:22 AM Hayato Kuroda (Fujitsu)
> <kuroda.hayato@fujitsu.com> wrote:
> >
> > But this is not correct anymore, 1462aad2 allows to alter two_phase option.
> > I was an original author, but I did oversight.
> >
> > I feel it can be fixed by referring the commit message, attached patch fixed like
> > that. How do you feel?
> >
>
> Thanks for the report and patch. I'll look into it.
>

We can now completely remove that comment, as the necessary details
are already present in subscriptioncmds.c. I have done that and pushed
the patch. Thanks.

--
With Regards,
Amit Kapila.

pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: Logical Replication of sequences
Next
From: Sutou Kouhei
Date:
Subject: Re: Make COPY format extendable: Extract COPY TO format implementations