On Sun, Aug 10, 2014 at 12:24 PM, Amit Kapila <
amit.kapila16@gmail.com> wrote:
>
> On Fri, Aug 8, 2014 at 11:41 AM, Fujii Masao <
masao.fujii@gmail.com> wrote:
> >
> > Yep, right. ParseConfigFp() is not good place to pick up data_directory.
> > What about the attached patch which makes ProcessConfigFile() instead of
> > ParseConfigFp() pick up data_directory just after the configuration file is
> > parsed?
>
> I think this is better way to handle it. Few comments about patch:
>
> 1. can't we directly have the code by having else in below loop.
> if (DataDir &&
> !ParseConfigFile(PG_AUTOCONF_FILENAME, NULL, false, 0, elevel,
> &head, &tail))
I think for this we need to change the above condition a bit.
