Postgres Pro
Downloads
Home   >   mailing lists

Re: CREATE SUBSCRIPTION -- add missing tab-completes - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: CREATE SUBSCRIPTION -- add missing tab-completes
Date
Msg-id CAA4eK1Kq3TX1bkDSHxJ9tYQA1ooVfHgG1+5G1EoAQKWAdPNyPQ@mail.gmail.com
Whole thread Raw
In response to CREATE SUBSCRIPTION -- add missing tab-completes  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: CREATE SUBSCRIPTION -- add missing tab-completes
Re: CREATE SUBSCRIPTION -- add missing tab-completes
List pgsql-hackers
Tree view 
On Wed, Apr 5, 2023 at 5:58 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> There are some recent comment that added new options for CREATE SUBSCRIPTION
>
...
> PSA patches to add those tab completions.
>

LGTM, so pushed. BTW, while looking at this, I noticed that newly
added options "password_required" and "run_as_owner" has incorrectly
mentioned their datatype as a string in the docs. It should be
boolean. I think "password_required" belongs to first section of docs
which says: "The following parameters control what happens during
subscription creation".

The attached patch makes those changes. What do you think?

--
With Regards,
Amit Kapila.
Attachment

pgsql-hackers by date:

Previous
From: "Drouvot, Bertrand"
Date:
Subject: Re: Minimal logical decoding on standbys
Next
From: Andres Freund
Date:
Subject: Re: Minimal logical decoding on standbys