Re: Forget close an open relation in ReorderBufferProcessTXN() - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Forget close an open relation in ReorderBufferProcessTXN()
Date
Msg-id CAA4eK1KkBEmbzPifY3Wq6kapNaERVMMwA2oXW52ZHAuT0HKbxA@mail.gmail.com
Whole thread Raw
In response to Forget close an open relation in ReorderBufferProcessTXN()  (Japin Li <japinli@hotmail.com>)
Responses Re: Forget close an open relation in ReorderBufferProcessTXN()  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Forget close an open relation in ReorderBufferProcessTXN()  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Thu, Apr 15, 2021 at 4:00 PM Japin Li <japinli@hotmail.com> wrote:
>
> The RelationIdGetRelation() comment says:
>
> > Caller should eventually decrement count. (Usually,
> > that happens by calling RelationClose().)
>
> However, it doesn't do it in ReorderBufferProcessTXN().
> I think we should close it, here is a patch that fixes it. Thoughts?
>

+1. Your fix looks correct to me but can we test it in some way?

-- 
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows
Next
From: Amit Kapila
Date:
Subject: Re: Truncate in synchronous logical replication failed