Postgres Pro
Downloads
Home   >   mailing lists

Re: PQexec() hangs on OOM - Mailing list pgsql-bugs

From Amit Kapila
Subject Re: PQexec() hangs on OOM
Date
Msg-id CAA4eK1KbDUBGDxfsJ=MDfJuvG3M78hF=SQmh24t86Kt+=ZBThg@mail.gmail.com
Whole thread Raw
In response to Re: PQexec() hangs on OOM  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: PQexec() hangs on OOM  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-bugs
Tree view
On Mon, Sep 7, 2015 at 1:40 PM, Michael Paquier <michael.paquier@gmail.com> wrote:
On Sat, Sep 5, 2015 at 9:45 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:

Now, to move into the serious things...

+       /*
+        * Advance inStart to show that the copy related message has been
+        * processed.
+        */
+       conn->inStart = conn->inCursor;
This change...

+                                       /* getCopyStart() moves
inStart itself */
                                        conn->asyncStatus = PGASYNC_COPY_IN;
-                                       break;
+                                       continue;
...  And this change are risky for a backpatch. And they actually
break the existing replication protocol

Can you please explain how will it break replication protocol? 
 
I have done the required handling for Copy Both mode as well in attached
patch similar to what was done for other Copy modes in previous patch.
Check if you still find it as broken for replication?

I have only kept the changes for COPY modes, so that once we settle on
those, I think similar changes could be done for getParamDescriptions()


With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
Attachment

pgsql-bugs by date:

Previous
From: Amit Kapila
Date:
Subject: Re: PQexec() hangs on OOM
Next
From: yoonghm@gmail.com
Date:
Subject: BUG #13617: ecpg cannot handle boolean field within a structure