Re: parallel mode and parallel contexts - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: parallel mode and parallel contexts
Date
Msg-id CAA4eK1KaNw6Rsr1eCv8tD4FPJFOurGCYU-HdsuOEkuJ9WNdaRw@mail.gmail.com
Whole thread Raw
In response to Re: parallel mode and parallel contexts  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: parallel mode and parallel contexts
List pgsql-hackers
On Wed, Jan 7, 2015 at 11:03 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>
> I have little doubt that this version is still afflicted with various
> bugs, and the heavyweight locking issue remains to be dealt with, but
> on the whole I think this is headed in the right direction.
>

+ParallelMain(Datum main_arg)
{
..
+ /*
+ * Now that we have a resource owner, we can attach to the dynamic
+ * shared memory 
segment and read the table of contents.
+ */
+ seg = dsm_attach(DatumGetInt32(main_arg));

Here, I think DatumGetUInt32() needs to be used instead of
DatumGetInt32() as the segment handle is uint32.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Parallel Seq Scan
Next
From: Andres Freund
Date:
Subject: Re: Proposal: Log inability to lock pages during vacuum