Re: Bugs in pgoutput.c - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Bugs in pgoutput.c
Date
Msg-id CAA4eK1KYdLj7yhN858SxLrwbtxtre1d=z94bpibZWwueYuHCnw@mail.gmail.com
Whole thread Raw
In response to Re: Bugs in pgoutput.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Bugs in pgoutput.c  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Thu, Feb 3, 2022 at 8:18 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Amit Kapila <amit.kapila16@gmail.com> writes:
> > Tom, is it okay for you if I go ahead with this patch after some testing?
>
> I've been too busy to get back to it, so sure.
>

Thanks. I have tested the patch by generating an invalidation message
for table DDL before accessing the syscache in
logicalrep_write_tuple(). I see that it correctly invalidates the
entry and rebuilds it for the next operation. I couldn't come up with
some automatic test for it so used the debugger to test it. I have
made a minor change in one of the comments. I am planning to push this
tomorrow unless there are comments or suggestions.

-- 
With Regards,
Amit Kapila.

Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: UNIQUE null treatment option
Next
From: Bharath Rupireddy
Date:
Subject: Re: Replace pg_controldata output fields with macros for better code manageability