Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot
Date
Msg-id CAA4eK1KB=7QOq6MkXo=4wrpq3FkqRACfT6VwKGDLa4UkeLQa2Q@mail.gmail.com
Whole thread Raw
In response to Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot  (Zhang Mingli <zmlpostgres@gmail.com>)
Responses Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot
List pgsql-hackers
On Wed, Sep 21, 2022 at 8:11 PM Zhang Mingli <zmlpostgres@gmail.com> wrote:
>
> On Sep 21, 2022, 22:22 +0800, Melih Mutlu <m.melihmutlu@gmail.com>, wrote:
>
> Hi hackers,
>
> Sharing a small patch to remove an unused parameter in SnapBuildGetOrBuildSnapshot function in snapbuild.c
>
> With commit 6c2003f8a1bbc7c192a2e83ec51581c018aa162f, SnapBuildBuildSnapshot no longer needs transaction id. This
alsomakes the xid parameter in SnapBuildGetOrBuildSnapshot useless.
 
> I couldn't see a reason to keep it and decided to remove it.
>
> Regards,
> Melih
>
> +1, Good Catch.
>

LGTM.

-- 
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: libpq error message refactoring
Next
From: Thomas Munro
Date:
Subject: Re: CI and test improvements