Postgres Pro
Downloads
Home   >   mailing lists

Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot - Mailing list pgsql-hackers

From Zhang Mingli
Subject Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot
Date
Msg-id 812aa0fa-3986-4a6d-be50-adcaf523e4ce@Spark
Whole thread Raw
In response to Removing unused parameter in SnapBuildGetOrBuildSnapshot  (Melih Mutlu <m.melihmutlu@gmail.com>)
Responses Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot
List pgsql-hackers
Tree view
On Sep 21, 2022, 22:22 +0800, Melih Mutlu <m.melihmutlu@gmail.com>, wrote:
Hi hackers,

Sharing a small patch to remove an unused parameter in SnapBuildGetOrBuildSnapshot function in snapbuild.c

With commit 6c2003f8a1bbc7c192a2e83ec51581c018aa162f, SnapBuildBuildSnapshot no longer needs transaction id. This also makes the xid parameter in SnapBuildGetOrBuildSnapshot useless.
I couldn't see a reason to keep it and decided to remove it.

Regards,
Melih
+1, Good Catch.

Regards,
Zhang Mingli

pgsql-hackers by date:

Previous
From: Junwang Zhao
Date:
Subject: Re: [PATCH] polish the error message of creating proc
Next
From: Julien Rouhaud
Date:
Subject: Re: [PATCH] polish the error message of creating proc