On Thu, Jun 23, 2022 at 8:43 AM shiy.fnst@fujitsu.com
<shiy.fnst@fujitsu.com> wrote:
>
> On Wed, Jun 22, 2022 4:49 PM Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > >
> > > This patch looks mostly good to me except for a few minor comments
> > > which are mentioned below. It is not very clear in which branch(es) we
> > > should commit this patch? As per my understanding, this is a
> > > pre-existing behavior but we want to document it because (a) It was
> > > not already documented, and (b) we followed it for row filters in
> > > PG-15 it seems that should be explained. So, we have the following
> > > options (a) commit it only for PG-15, (b) commit for PG-15 and
> > > backpatch the relevant sections, or (c) commit it when branch opens
> > > for PG-16. What do you or others think?
> >
> > Even though this is a very old docs omission, AFAIK nobody ever raised
> > it as a problem before. It only became more important because of the
> > PG15 row-filters. So I think option (a) is ok.
> >
>
> I also think option (a) is ok.
>
> >
> > PSA patch v4 to address all the above review comments.
> >
>
> Thanks for updating the patch. It looks good to me.
>
The patch looks good to me as well. I will push this patch in HEAD (as
per option (a)) tomorrow unless I see any more suggestions/comments.
--
With Regards,
Amit Kapila.
