Re: parallel vacuum comments - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: parallel vacuum comments
Date
Msg-id CAA4eK1K5E0Hsd-iBE2oO8WAGL6p+iagqWRPP=-9E1EHyrNtpCw@mail.gmail.com
Whole thread Raw
In response to Re: parallel vacuum comments  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: parallel vacuum comments  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
On Thu, Dec 9, 2021 at 6:05 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> On Thu, Dec 9, 2021 at 7:44 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> Agreed with the above two points.
>
> I've attached updated patches that incorporated the above comments
> too. Please review them.
>

I have made the following minor changes to the 0001 patch: (a) An
assert was removed from dead_items_max_items() which I added back. (b)
Removed an unnecessary semicolon from one of the statements in
compute_parallel_vacuum_workers(). (c) Changed comments at a few
places. (d) moved all parallel_vacuum_* related functions together.
(e) ran pgindent and slightly modify the commit message.

Let me know what you think of the attached?

-- 
With Regards,
Amit Kapila.

Attachment

pgsql-hackers by date:

Previous
From: Jakub Wartak
Date:
Subject: RE: track_io_timing default setting
Next
From: Peter Eisentraut
Date:
Subject: Re: Column Filtering in Logical Replication