Re: Add 'worker_type' to pg_stat_subscription - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Add 'worker_type' to pg_stat_subscription
Date
Msg-id CAA4eK1JwYF-Xc55vZU2Lawdpo7C8nFdSwMYV7-Z0YEc4kZ4xbg@mail.gmail.com
Whole thread Raw
In response to Re: Add 'worker_type' to pg_stat_subscription  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: Add 'worker_type' to pg_stat_subscription
List pgsql-hackers
On Sun, Sep 17, 2023 at 2:10 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> On Sat, Sep 16, 2023 at 06:09:48PM +0530, Amit Kapila wrote:
>
> This still leaves the possibility for confusion with the documentation's
> use of "leader apply worker", but I haven't touched that for now.
>

We may want to fix that separately but as you have raised here, I
found the following two places in docs which could be a bit confusing.

"Specifies maximum number of logical replication workers. This
includes leader apply workers, parallel apply workers, and table
synchronization"

""OID of the relation that the worker is synchronizing; NULL for the
leader apply worker and parallel apply workers"

One simple idea to reduce confusion could be to use (leader) in the
above two places. Do you see any other place which could be confusing
and what do you suggest to fix it?

--
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: remaining sql/json patches
Next
From: David Rowley
Date:
Subject: Re: make add_paths_to_append_rel aware of startup cost