Re: old_snapshot_threshold allows heap:toast disagreement - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: old_snapshot_threshold allows heap:toast disagreement
Date
Msg-id CAA4eK1JtNAEh5pKufPFMBxbVmExPURXOMOmbhd9DK8FqE5hLgw@mail.gmail.com
Whole thread Raw
In response to Re: old_snapshot_threshold allows heap:toast disagreement  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Wed, Aug 3, 2016 at 2:22 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Thu, Jul 28, 2016 at 7:29 PM, Andres Freund <andres@anarazel.de> wrote:
>
> Yeah.  Actually, consistent with the above, I discovered that as long
> as we consult both the active snapshot stack and the pairingheap of
> registered snapshots, it seems to be fine to just insist that we
> always get a snapshot back from the snapmgr and use that to initialize
> the TOAST snapshot.  So I did it that way in the attached version.
>
> New patch attached.
>

Code looks good to me.  I have not tested the patch.



-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: Why we lost Uber as a user
Next
From: Pavel Stehule
Date:
Subject: Re: Surprising behaviour of \set AUTOCOMMIT ON