On Mon, Apr 4, 2016 at 11:39 PM, Julien Rouhaud <julien.rouhaud@dalibo.com> wrote: > > On 04/04/2016 17:03, Julien Rouhaud wrote: > > On 04/04/2016 08:55, Amit Kapila wrote: > > > > Thanks for the review! > > > >> Few comments: > >> 1. > >> + limited according to the <xref linkend="gux-max-parallel-degree"> > >> > >> A. typo. > >> /gux-max-parallel-degree/guc-max-parallel-degree > >> /worker/workers > > > > Oops, fixed. > > > > And I managed to no fix it, sorry :/ Thanks to Andreas who warned me. >
Few more comments:
1.
@@ -909,6 +909,17 @@ CREATE [ [ GLOBAL | LOCAL ] { TEMPORARY | TEMP } | UNLOGGED ] TABLE [ IF NOT EXI
+ Sets the degree of parallelism for an individual relation. The requested
+ number of workers will be
limited by <xref
+ linkend="guc-max-parallel-degree">.
+ </para>
+ </listitem>
+ </varlistentry>
All other parameters in this category are supportted by Alter table command as well, so I think this parameter should also be supported by Alter Table command (for both SET and RESET variants).
2.
+"Number of parallel processes per executor node wanted for this relation.",
How about
Number of parallel processes that can be used for this relation per executor node.
A. Second line should be indented with the begin of first line after bracket '(' which means with rel->pages. Refer multiline condition in near by code. Or you can run pgindent.
B. The comment above this condition needs slight adjustment as per new condition.
4.
+intparallel_degree; /* max number of parallel worker */
