Re: backup manifests - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: backup manifests
Date
Msg-id CAA4eK1JsOvZaYAeXsU8tDvrycodPBn4-MUbo1hTZNwZaBRAO=w@mail.gmail.com
Whole thread Raw
In response to Re: backup manifests  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Tue, Mar 24, 2020 at 10:30 PM Robert Haas <robertmhaas@gmail.com> wrote:
>
> On Mon, Mar 23, 2020 at 11:43 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > All others except one are passing now.  See the summary of the failed
> > test below and attached are failed run logs.
> >
> > Test Summary Report
> > -------------------
> > t/003_corruption.pl  (Wstat: 65280 Tests: 14 Failed: 0)
> >   Non-zero exit status: 255
> >   Parse errors: Bad plan.  You planned 44 tests but ran 14.
> > Files=6, Tests=123, 164 wallclock secs ( 0.06 usr +  0.02 sys =  0.08 CPU)
> > Result: FAIL
>
> Hmm. It looks like it's trying to remove the symlink that points to
> the tablespace directory, and failing with no error message. I could
> set that permutation to be skipped on Windows, or maybe there's an
> alternate method you can suggest that would work?
>

We can use rmdir() for Windows.  The attached patch fixes the failure
for me. I have tried the test on CentOS as well after the fix and it
passes there as well.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: "k.jamison@fujitsu.com"
Date:
Subject: RE: [Patch] Optimize dropping of relation buffers using dlist
Next
From: Rajkumar Raghuwanshi
Date:
Subject: Re: WIP/PoC for parallel backup