Re: [COMMITTERS] pgsql: pageinspect: Try to fix some bugs in previous commit. - Mailing list pgsql-committers

On Fri, Feb 3, 2017 at 8:13 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Amit Kapila <amit.kapila16@gmail.com> writes:
>> I have gone through all the of the SQL declarations and it seems
>> hash_metapage_info(...,OUT procid int4,..) is not consistent.  procid
>> is unsigned int, so isn't it better to use the corresponding datatype
>> as int8 in SQL function hash_metapage_info then use Int64GetDatum?
>
> Isn't procid an OID?
>

It is RegProcedure.

>  I'd use OID or maybe even regprocedure on
> the SQL side.
>

I think we can use either one of those.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com