Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Date
Msg-id CAA4eK1JZS8d8W2tRYht+mXM9FQp2GBSmP+avrDZWU4YgeepyQQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher  (Andres Freund <andres@anarazel.de>)
Responses Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
List pgsql-hackers
On Wed, Mar 1, 2023 at 12:09 AM Andres Freund <andres@anarazel.de> wrote:
>
> > I see this as a way to provide this feature for users but I would
> > prefer to proceed with this if we can get some more buy-in from senior
> > community members (at least one more committer) and some user(s) if
> > possible. So, I once again request others to chime in and share their
> > opinion.
>
> I'd prefer not having an option, because we figure out the cause of the
> performance regression (reducing it to be small enough to not care). After
> that an option defaulting to using indexes.
>

Sure, if we can reduce regression to be small enough then we don't
need to keep the default as false, otherwise, also, we can consider it
to keep an option defaulting to using indexes depending on the
investigation for regression. Anyway, the main concern was whether it
is okay to have an option for this which I think we have an agreement
on, now I will continue my review.

--
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Simplify standby state machine a bit in WaitForWALToBecomeAvailable()
Next
From: Juan José Santamaría Flecha
Date:
Subject: Re: WIN32 pg_import_system_collations