On Mon, Dec 19, 2022 at 6:17 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Sat, Dec 17, 2022 at 7:34 PM houzj.fnst@fujitsu.com
> <houzj.fnst@fujitsu.com> wrote:
> >
> > Agreed. I have addressed all the comments and did some cosmetic changes.
> > Attach the new version patch set.
> >
>
> Few comments:
> ============
>
Few more minor points:
1.
-static inline void
+void
changes_filename(char *path, Oid subid, TransactionId xid)
{
This function seems to be used only in worker.c. So, what is the need
to make it extern?
2. I have made a few changes in the comments. See attached. This is
atop my yesterday's top-up patch.
I think we should merge the 0001 and 0002 patches as they need to be
committed together.
--
With Regards,
Amit Kapila.
