Re: [bug fix] pg_ctl always uses the same event source - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: [bug fix] pg_ctl always uses the same event source
Date
Msg-id CAA4eK1JQZpSBwK=ohe4HK5OPWAT8JRQZDSmtzR_rrUF4rEk3Xg@mail.gmail.com
Whole thread Raw
In response to Re: [bug fix] pg_ctl always uses the same event source  ("MauMau" <maumau307@gmail.com>)
List pgsql-hackers
On Mon, Mar 10, 2014 at 2:39 PM, MauMau <maumau307@gmail.com> wrote:
> From: "Amit Kapila" <amit.kapila16@gmail.com>
>
>>> If I understand correctly that objection was on changing Default Event
>>> Source name, and the patch now doesn't contain that change, it's
>>> just a bug fix for letting pg_ctl know the non-default event source
>>> set by user.
>>>
>>> Please clarify if I misunderstood something, else this should be changed
>>> to Ready For Committer.
>>
>>
>> Tom/Andres, please let me know if you have objection for this patch,
>> because
>> as per my understanding all the objectionable part of patch is removed
>> from final
>> patch and it's a defect fix to make pg_ctl aware of Event Source name set
>> in
>> postgresql.conf.
>>
>> If there is no objection, I will again change it to Ready For Committer.
>
>
> Hi, Amit-san, I really appreciate your cooperation.

Thanks.

> Yes, I removed the
> default value change that caused objection, so the patch can be marked ready
> for committer.  I understand the patch was marked needs for review by
> misunderstanding Tom-san's opinion.
>
> I remember that I read "silence means no objection, or implicit agreement"
> somewhere in the community site or ML.  So I think it would be no problem to
> set the status to ready for committer again.

Okay, Done.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Retain dynamic shared memory segments for postmaster lifetime
Next
From: Tom Lane
Date:
Subject: Re: Why is AccessShareLock held until end of transaction?