Postgres Pro
Downloads
Home   >   mailing lists

Re: possible deadlock: different lock ordering for heap pages - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: possible deadlock: different lock ordering for heap pages
Date
Msg-id CAA4eK1JPoxJqi73KqRJobjnL=gpPxVedyiRrMQPBDueYvkG0jw@mail.gmail.com
Whole thread Raw
In response to Re: possible deadlock: different lock ordering for heap pages  ("Nishant, Fnu" <nishantf@amazon.com>)
Responses Re: possible deadlock: different lock ordering for heap pages  ("Nishant, Fnu" <nishantf@amazon.com>)
Re: possible deadlock: different lock ordering for heap pages  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Tree view 
On Mon, Jan 21, 2019 at 10:39 PM Nishant, Fnu <nishantf@amazon.com> wrote:
>
> Thanks Amit for your review.
>
> On 1/20/19, 6:55 AM, "Amit Kapila" <amit.kapila16@gmail.com> wrote:
>     > I think you need to change below code as well....
>        Assert(buffer2 == InvalidBuffer || buffer1 <= buffer2);
>
> Done. Updated the patch.
>

Attached is an updated patch.  I have edited comments and commit
message in the patch.  I would like to backpatch this till 9.4 unless
anyone thinks otherwise.

BTW, do you have a reproducible test case for this fix?  How did you
catch this, browsing code?

How do we pronounce your name, is Nishant Fnu okay?  I would like to
mention you as the author of the patch, so need to write your name.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
Attachment

pgsql-hackers by date:

Previous
From: "Tsunakawa, Takayuki"
Date:
Subject: RE: reloption to prevent VACUUM from truncating empty pages at theend of relation
Next
From: "Nishant, Fnu"
Date:
Subject: Re: possible deadlock: different lock ordering for heap pages