Re: Confusing comment for function ExecParallelEstimate - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Confusing comment for function ExecParallelEstimate
Date
Msg-id CAA4eK1JP==FNpzd=CHC=mnCrLPg1bN5RyZAuk8AUdLYfh_yq7Q@mail.gmail.com
Whole thread Raw
In response to RE: Confusing comment for function ExecParallelEstimate  ("Wu, Fei" <wufei.fnst@cn.fujitsu.com>)
Responses Re: Confusing comment for function ExecParallelEstimate
List pgsql-hackers
On Thu, Jun 6, 2019 at 7:37 AM Wu, Fei <wufei.fnst@cn.fujitsu.com> wrote:
>
> Sorry, Last mail forget to CC the mailing list.
>
> Now the comment is confusing, Maybe someone should correct it.
>

Sure, for the sake of clarity, when this code was initially introduced
in commit d1b7c1ff, the structure used was
SharedPlanStateInstrumentation, but later when it got changed to
Instrumentation structure in commit b287df70, we forgot to update the
comment.  So, we should backpatch this till 9.6 where it got
introduced.  I will commit this change by tomorrow or so.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: "Wu, Fei"
Date:
Subject: RE: Confusing comment for function ExecParallelEstimate
Next
From: David Rowley
Date:
Subject: Re: Should we warn against using too many partitions?