Re: postgresql.auto.conf and reload - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: postgresql.auto.conf and reload
Date
Msg-id CAA4eK1JJR7PG-wCN3mS9T9qPr=KbQquyML+SXKPmWBSN8x5cEQ@mail.gmail.com
Whole thread Raw
In response to Re: postgresql.auto.conf and reload  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: postgresql.auto.conf and reload
List pgsql-hackers
On Wed, Aug 6, 2014 at 1:32 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Tue, Jul 29, 2014 at 9:26 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > The reason is that during startup DataDir is not set by the time server
> > processes config file due to which we process .auto.conf file in second
> > pass.  I think ideally it should ignore the invalid setting in such a case
> > as it does during reload, however currently there is no good way to
> > process .auto.conf  incase DataDir is not set, so we handle it separately
> > in second pass.
>
> What about picking up only data_directory at the first pass?

I think that will workout and for that I think we might need to add
few checks during ProcessConfigFile.  Do you want to address it
during parsing of config file or during setting of values?

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: postgresql.auto.conf and reload
Next
From: Fujii Masao
Date:
Subject: Re: pg_export_snapshot on standby side