Re: Adjust the description of OutputPluginCallbacks in pg-doc - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Adjust the description of OutputPluginCallbacks in pg-doc
Date
Msg-id CAA4eK1J8iWB9RG2OgdoLDYSDOfK4Qu530Ep8j=0XoEy7s+ih0w@mail.gmail.com
Whole thread Raw
In response to Adjust the description of OutputPluginCallbacks in pg-doc  ("wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>)
Responses Re: Adjust the description of OutputPluginCallbacks in pg-doc
RE: Adjust the description of OutputPluginCallbacks in pg-doc
List pgsql-hackers
On Wed, Jan 11, 2023 at 4:20 PM wangw.fnst@fujitsu.com
<wangw.fnst@fujitsu.com> wrote:
>
> When I was reading the "Logical Decoding Output Plugins" chapter in pg-doc [1],
> I think in the summary section, only the callback message_cb is not described
> whether it is required or optional, and the description of callback
> stream_prepare_cb seems inaccurate.
>
> And after the summary section, I think only the callback stream_xxx_cb section
> and the callback truncate_cb section are not described this tag (are they
> required or optional).
>
> I think we could improve these to be more reader friendly. So I tried to write
> a patch for these and attach it.
>
> Any thoughts?
>

This looks mostly good to me. I have made minor adjustments in the
attached. Do those make sense to you?

-- 
With Regards,
Amit Kapila.

Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: ExecRTCheckPerms() and many prunable partitions (checkAsUser)
Next
From: vignesh C
Date:
Subject: Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?)