Re: PATCH: add pg_current_xlog_flush_location function - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: PATCH: add pg_current_xlog_flush_location function
Date
Msg-id CAA4eK1J4P7vOcSK83dXrFBJ_7P0_veGekpPygkMEH7yxx7ypRg@mail.gmail.com
Whole thread Raw
In response to PATCH: add pg_current_xlog_flush_location function  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
Responses Re: PATCH: add pg_current_xlog_flush_location function
List pgsql-hackers
On Sun, Dec 13, 2015 at 12:07 AM, Tomas Vondra <tomas.vondra@2ndquadrant.com> wrote:
Hi,

attached is a patch adding a function pg_current_xlog_flush_location(), which proved quite useful when investigating the ext4 data loss bug. It's mostly what was already sent to that thread, except for docs that were missing in the initial version.


 /*

+ * Get latest WAL flush pointer

+ */

+XLogRecPtr

+GetXLogFlushRecPtr(void)

+{

+ SpinLockAcquire(&XLogCtl->info_lck);

+ LogwrtResult = XLogCtl->LogwrtResult;

+ SpinLockRelease(&XLogCtl->info_lck);

+

+ return LogwrtResult.Flush;

+}

+



Is there a reason why you can't use existing function
GetFlushRecPtr() in xlog.c?




With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Rework the way multixact truncations work
Next
From: Amit Kapila
Date:
Subject: Re: PATCH: track last known XLOG segment in control file