Re: Explain buffers wrong counter with parallel plans - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Explain buffers wrong counter with parallel plans
Date
Msg-id CAA4eK1J3cH-y9K+2DOYLLOu9zFqf+aAQgKK3BFw4c661e7FSEw@mail.gmail.com
Whole thread Raw
In response to Re: Explain buffers wrong counter with parallel plans  ("Jonathan S. Katz" <jonathan.katz@excoventures.com>)
Responses Re: Explain buffers wrong counter with parallel plans  ("Jonathan S. Katz" <jonathan.katz@excoventures.com>)
Re: Explain buffers wrong counter with parallel plans  (Andres Freund <andres@anarazel.de>)
Re: Explain buffers wrong counter with parallel plans  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Fri, Jul 27, 2018 at 11:12 PM, Jonathan S. Katz
<jonathan.katz@excoventures.com> wrote:
>
>> On Jul 27, 2018, at 8:31 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
>>
>>
>> Yeah, that would be better.  Today, I have tried the patch on both
>> Head and PG11 and I am getting same and correct results.
>
> I have applied the the patch to PG11beta2 and tested.
>

I think we should backpatch this till 9.6 where the parallel query was
introduced.  Note, that for HEAD and 11, the patch is same.  For PG10,
the patch code is same, but because surrounding code is different, the
same patch didn't apply.  For 9.6, we don't need to collect stats in
ExecShutdownNode.   I have tested it in all the back branches and it
works fine.

Robert,

We have done verification that the approach works and fixes the bug in
all known cases.  Do you see any problem with this approach?

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Bizarre behavior in libpq's searching of ~/.pgpass
Next
From: Minh-Quan Tran
Date:
Subject: Re: Segfault logical replication PG 10.4